]> dgit.raspbian.org Git - gnome-shell.git/commit
keyboard: Don't press and release keyval if it's a modifier key
authorJonas Dreßler <verdre@v0yd.nl>
Sun, 17 Nov 2024 18:16:58 +0000 (19:16 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Sat, 23 Nov 2024 12:18:50 +0000 (13:18 +0100)
commita44c8fb3f0eee8a88a11c70558bcdc852eb3a64e
tree7ada6b94972aa51a25f8559d19b0efbb6b6e59f6
parentdefdd8784653bdf4147b0b9a45d9bf7cdc5367f2
keyboard: Don't press and release keyval if it's a modifier key

Looks like we currently do the press-and-release dance for keys that specify
both a keyval and the "modifier" action. So when pressing CTRL in the
extended OSK, not only is the CTRL modifier set together with the next key
pressed, but the actual CTRL keyval quickly gets pressed and released,
similar to how we'd do it for the TAB key.

This seems unintentional, as the press-and-release behavior should probably
be specific to keys like TAB, and not apply to modifier keys, so limit that
behavior to only keys without an action specified.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3286>
(cherry picked from commit cae8b745cab97056d7fee9aa30053817f44f53ad)
js/ui/keyboard.js